Skip to content

Conversation

@Lu-Jiejie
Copy link
Contributor

A Flow-Launcher plugin that translates text using multiple translation services.

@cibere
Copy link
Contributor

cibere commented Jun 15, 2025

Unless you have a specific reason for your current settings system, could you please switch to using flow's builtin settings system? You can see the relevant docs for defining them here

@Lu-Jiejie
Copy link
Contributor Author

Unless you have a specific reason for your current settings system, could you please switch to using flow's builtin settings system? You can see the relevant docs for defining them here

I was planning to use this built-in settings system, but I couldn't find out how to translate it to other languages, since my main target group is native Chinese speakers, and I work in Typescript. I'll migrate over and use English.

@Lu-Jiejie
Copy link
Contributor Author

@cibere I have completed migrating plugin settings to Flow Launcher's built-in settings system. Please review again, thanks

@Jack251970
Copy link
Member

@Lu-Jiejie I wonder if you can split your description with more lines. It looks like you are putting too much character in one line.

image image

@Lu-Jiejie
Copy link
Contributor Author

Lu-Jiejie commented Jun 17, 2025

@Lu-Jiejie我想知道你是否可以用更多行来分割你的描述。看起来你在一行中写得太多了。

image image

Done

example

@Jack251970 Jack251970 requested a review from cibere June 17, 2025 12:26
@jjw24 jjw24 merged commit 91a2b4e into Flow-Launcher:plugin_api_v2 Jun 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants